Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about data-aware mixed precision assignment #1075

Merged

Conversation

nikita-savelyevv
Copy link
Collaborator

@nikita-savelyevv nikita-savelyevv commented Dec 16, 2024

What does this PR do?

Recently there appeared a confusion regarding when the dataset argument actually affects the resulting model. I've added some notes to help clarifying this.

Namely, if users provide compression ratio<1 and a dataset at the same time, according to NNCF data-aware mixed precision using MAX_ACTIVATION_VARIANCE criterion will be applied. https://github.com/openvinotoolkit/nncf/blob/develop/nncf/quantization/algorithms/weight_compression/algorithm.py#L96

Otherwise, if no data-aware compression algorithm is selected, dataset argument is not used.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@nikita-savelyevv nikita-savelyevv marked this pull request as ready for review December 16, 2024 10:04
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@helena-intel helena-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition @nikita-savelyevv !

docs/source/openvino/export.mdx Show resolved Hide resolved
@echarlaix echarlaix merged commit f030583 into huggingface:main Dec 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants